From 544eebd7157ed1d9fa6256e13cdb2fee2cf96960 Mon Sep 17 00:00:00 2001
From: PaulVua <paulvuarambon@gmail.com>
Date: Tue, 10 Feb 2026 17:05:10 +0100
Subject: [PATCH] feat(ui): add NextPM firmware version button on sensors page

Add a "Firmware Version" button next to "Get Data" in the NextPM card
that calls firmware_version.py and displays the result as a badge.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 html/launcher.php |  7 +++++++
 html/saraR4.html  | 26 +++++++++++++-------------
 html/sensors.html | 30 ++++++++++++++++++++++++++++++
 3 files changed, 50 insertions(+), 13 deletions(-)

diff --git a/html/launcher.php b/html/launcher.php
index 5f8a66a..3c17c4e 100755
--- a/html/launcher.php
+++ b/html/launcher.php
@@ -608,6 +608,13 @@ if ($type == "npm") {
     echo $output;
 }
 
+if ($type == "npm_firmware") {
+    $port=$_GET['port'];
+    $command = 'sudo /usr/bin/python3 /var/www/nebuleair_pro_4g/NPM/firmware_version.py ' . $port;
+    $output = shell_exec($command);
+    echo $output;
+}
+
 if ($type == "envea") {
     $port=$_GET['port'];
     $name=$_GET['name'];
diff --git a/html/saraR4.html b/html/saraR4.html
index df0009e..d1f2107 100755
--- a/html/saraR4.html
+++ b/html/saraR4.html
@@ -375,6 +375,14 @@
                 </div>
 
                 <div class="list-group" id="selftest_results">
+                  <!-- Dynamic sensor test entries will be added here -->
+                  <div id="sensor_tests_container"></div>
+
+                  <!-- Separator for communication tests -->
+                  <div id="comm_tests_separator" class="list-group-item bg-light text-center py-1" style="display:none;">
+                    <small class="text-muted fw-bold">COMMUNICATION</small>
+                  </div>
+
                   <!-- Info: WiFi Status -->
                   <div class="list-group-item d-flex justify-content-between align-items-center" id="test_wifi">
                     <div>
@@ -384,7 +392,7 @@
                     <span id="test_wifi_status" class="badge bg-secondary">Pending</span>
                   </div>
 
-                  <!-- Test 1: Modem Connection -->
+                  <!-- Test: Modem Connection -->
                   <div class="list-group-item d-flex justify-content-between align-items-center" id="test_modem">
                     <div>
                       <strong>Modem Connection</strong>
@@ -393,7 +401,7 @@
                     <span id="test_modem_status" class="badge bg-secondary">Pending</span>
                   </div>
 
-                  <!-- Test 2: SIM Card -->
+                  <!-- Test: SIM Card -->
                   <div class="list-group-item d-flex justify-content-between align-items-center" id="test_sim">
                     <div>
                       <strong>SIM Card</strong>
@@ -402,7 +410,7 @@
                     <span id="test_sim_status" class="badge bg-secondary">Pending</span>
                   </div>
 
-                  <!-- Test 3: Signal Strength -->
+                  <!-- Test: Signal Strength -->
                   <div class="list-group-item d-flex justify-content-between align-items-center" id="test_signal">
                     <div>
                       <strong>Signal Strength</strong>
@@ -411,7 +419,7 @@
                     <span id="test_signal_status" class="badge bg-secondary">Pending</span>
                   </div>
 
-                  <!-- Test 4: Network Connection -->
+                  <!-- Test: Network Connection -->
                   <div class="list-group-item d-flex justify-content-between align-items-center" id="test_network">
                     <div>
                       <strong>Network Connection</strong>
@@ -419,14 +427,6 @@
                     </div>
                     <span id="test_network_status" class="badge bg-secondary">Pending</span>
                   </div>
-
-                  <!-- Separator for sensor tests -->
-                  <div id="sensor_tests_separator" class="list-group-item bg-light text-center py-1" style="display:none;">
-                    <small class="text-muted fw-bold">SENSOR TESTS</small>
-                  </div>
-
-                  <!-- Dynamic sensor test entries will be added here -->
-                  <div id="sensor_tests_container"></div>
                 </div>
 
                 <!-- Logs section -->
@@ -1612,8 +1612,8 @@ function resetSelfTestUI() {
   document.getElementById('test_network_detail').textContent = 'Waiting...';
 
   // Reset sensor tests
-  document.getElementById('sensor_tests_separator').style.display = 'none';
   document.getElementById('sensor_tests_container').innerHTML = '';
+  document.getElementById('comm_tests_separator').style.display = 'none';
 
   // Reset logs
   document.getElementById('selftest_logs').innerHTML = '';
diff --git a/html/sensors.html b/html/sensors.html
index 6323602..b732afc 100755
--- a/html/sensors.html
+++ b/html/sensors.html
@@ -145,6 +145,33 @@ function getNPM_values(port){
             });
         }
         
+function getNPM_firmware(port){
+      console.log("Firmware version from NPM (port "+port+"):");
+      $("#loading_fw_"+port).show();
+
+            $.ajax({
+              url: 'launcher.php?type=npm_firmware&port='+port,
+              dataType: 'json',
+              method: 'GET',
+              success: function(response) {
+                        console.log(response);
+                        $("#loading_fw_"+port).hide();
+                        const fwSpan = document.getElementById("fw_version_"+port);
+                        if (response.firmware_version !== undefined) {
+                            fwSpan.innerHTML = '<span class="badge bg-success">Firmware: ' + response.firmware_version + '</span>';
+                        } else {
+                            fwSpan.innerHTML = '<span class="badge bg-danger">Error reading firmware</span>';
+                        }
+                    },
+                    error: function(xhr, status, error) {
+                        console.error('AJAX request failed:', status, error);
+                        $("#loading_fw_"+port).hide();
+                        const fwSpan = document.getElementById("fw_version_"+port);
+                        fwSpan.innerHTML = '<span class="badge bg-danger">Error</span>';
+                    }
+            });
+        }
+
 function getENVEA_values(port, name){
     console.log("Data from Envea " + name + " (port " + port + "):");
     $("#loading_envea" + name).show();
@@ -369,8 +396,11 @@ error: function(xhr, status, error) {
             <h5 class="card-title" data-i18n="sensors.npm.title">NextPM</h5>
             <p class="card-text" data-i18n="sensors.npm.description">Capteur particules fines.</p>
             <button class="btn btn-primary" onclick="getNPM_values('ttyAMA5')" data-i18n="common.getData">Get Data</button>
+            <button class="btn btn-secondary" onclick="getNPM_firmware('ttyAMA5')">Firmware Version</button>
             <br>
             <div id="loading_ttyAMA5" class="spinner-border spinner-border-sm" style="display: none;" role="status"></div>
+            <div id="loading_fw_ttyAMA5" class="spinner-border spinner-border-sm" style="display: none;" role="status"></div>
+            <div id="fw_version_ttyAMA5" class="mt-1"></div>
             <table class="table table-striped-columns">
               <tbody id="data-table-body_ttyAMA5"></tbody>
             </table>